always set 'use_default_shell_env' in ctx.actions.run #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aspect uses shell wrappers that invoke tools like `dirname` and `uname`. When the default shell env is not inherited, this prevents tools from being found on systems without a working fallback $PATH (like NixOS). See also: NixOS/nixpkgs#289505
|
thanks for this fix! any chance to merge that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aspect uses shell wrappers that invoke tools like
dirnameanduname. When the default shell env is not inherited, this prevents tools from being found on systems without a working fallback $PATH (like NixOS).This might be incompatible with setting the
envattribute, unless the bazel flag--incompatible_merge_fixed_and_default_shell_envis set on Bazel versions < 7.See also: NixOS/nixpkgs#289505
Changes are visible to end-users: no
Test plan